Skip to content

feat(eth): Allow setting the RX task stack size #10003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2024
Merged

feat(eth): Allow setting the RX task stack size #10003

merged 2 commits into from
Jul 10, 2024

Conversation

me-no-dev
Copy link
Member

Default stack size of 2K might not be enough in some cases. Increase the default to safer 4K and allow setting it to custom value.

Fixes: #10001

@me-no-dev
feat(eth): Allow setting the RX task stack size
697fd0d 
Default stack size of 2K might not be enough in some cases. Increase the default to safer 4K and allow setting it to custom value.
@me-no-dev me-no-dev mentioned this pull request Jul 10, 2024
Closed
1 task
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 10, 2024 •
edited
Loading

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "feat(eth): Allow setting the RX task stack size":
    • body's lines must not be longer than 100 characters

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello me-no-dev, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against cd49756

@me-no-dev me-no-dev added the Status: Review needed Issue or PR is awaiting review label Jul 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 10, 2024 •
edited
Loading

Test Results

 56 files  ±0   56 suites  ±0   4m 47s ⏱️ -31s
 21 tests ±0   21 ✅ ±0  0 💤 ±0  0 ❌ ±0 
135 runs  ±0  135 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit cd49756. ± Comparison against base commit 4e3523c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S30⚠️ +120.000.00000.000.00
ESP32S20⚠️ +120.000.00000.000.00
ESP32C3000.000.00000.000.00
ESP32C6000.000.00000.000.00
ESP32H20⚠️ +100.000.00000.000.00
ESP320⚠️ +160.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
Ethernet/examples/ETH_W5500_Arduino_SPI00000000⚠️ +100⚠️ +160
Ethernet/examples/ETH_W5500_IDF_SPI⚠️ +120⚠️ +120000000⚠️ +160
Ethernet/examples/ETH_LAN8720----------⚠️ +160
Ethernet/examples/ETH_TLK110----------⚠️ +160

@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Jul 10, 2024
@me-no-dev me-no-dev merged commit 0adf787 into master Jul 10, 2024
43 checks passed
@me-no-dev me-no-dev deleted the feature/eth_task_stack_size branch July 10, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

Assignees
No one assigned
Labels
Status: Pending Merge Pull Request is ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

W5500 crash : Stack canary watchpoint triggered (w5500_tsk)
2 participants
@me-no-dev @P-R-O-C-H-Y